Commit61dfc4d

committed

set active_command_id to None, not active_op_handle

Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>

1 parent9fb6a76 commit61dfc4dCopy full SHA for 61dfc4d

File tree

-16

lines changed

-16

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1079,7 +1079,7 @@ def cancel(self) -> None:`
`1079`	`1079`	`defclose(self)->None:`
`1080`	`1080`	`"""Close cursor"""`
`1081`	`1081`	`self.open=False`
`1082`		`-self.active_op_handle=None`
	`1082`	`+self.active_command_id=None`
`1083`	`1083`	`ifself.active_result_set:`
`1084`	`1084`	`self._close_and_clear_active_result_set()`
`1085`	`1085`

Lines changed: 0 additions & 15 deletions

Original file line number	Diff line number	Diff line change
`@@ -260,21 +260,6 @@ def test_context_manager_closes_cursor(self):`
`260`	`260`	`cursor.close=mock_close`
`261`	`261`	`mock_close.assert_called_once_with()`
`262`	`262`
`263`		`-@patch("%s.client.ThriftBackend"%PACKAGE_NAME)`
`264`		`-deftest_context_manager_closes_connection(self,mock_client_class):`
`265`		`-instance=mock_client_class.return_value`
`266`		`-`
`267`		`-mock_open_session_resp=MagicMock(spec=TOpenSessionResp)()`
`268`		`-mock_open_session_resp.sessionHandle.sessionId=b"\x22"`
`269`		`-instance.open_session.return_value=mock_open_session_resp`
`270`		`-`
`271`		`-withdatabricks.sql.connect(**self.DUMMY_CONNECTION_ARGS)asconnection:`
`272`		`-pass`
`273`		`-`
`274`		`-# Check the close session request has an id of x22`
`275`		`-close_session_id=instance.close_session.call_args[0][0].sessionId`
`276`		`-self.assertEqual(close_session_id,b"\x22")`
`277`		`-`
`278`	`263`	`defdict_product(self,dicts):`
`279`	`264`	`"""`
`280`	`265`	`Generate cartesion product of values in input dictionary, outputting a dictionary`

Comments

(0)