Commit31a0e52

committed

n_valid_rows -> num_rows

Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>

1 parent14c5625 commit31a0e52Copy full SHA for 31a0e52

File tree

3 files changed

-8

lines changed

src/databricks/sql
- utils.py
tests/unit
- test_sea_queue.py
- test_sea_result_set.py

3 files changed

-8

lines changed

`‎src/databricks/sql/utils.py‎`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,6 @@ def build_queue(`
`118`	`118`	`manifest:Optional[ResultManifest],`
`119`	`119`	`statement_id:str,`
`120`	`120`	`description:List[Tuple]= [],`
`121`		`-schema_bytes:Optional[bytes]=None,`
`122`	`121`	`max_download_threads:Optional[int]=None,`
`123`	`122`	`sea_client:Optional[SeaDatabricksClient]=None,`
`124`	`123`	`lz4_compressed:bool=False,`
`@@ -141,6 +140,7 @@ def build_queue(`
`141`	`140`	`ResultSetQueue: The appropriate queue for the result data`
`142`	`141`	`"""`
`143`	`142`
	`143`	`+print(sea_result_data)`
`144`	`144`	`ifsea_result_data.dataisnotNone:`
`145`	`145`	`# INLINE disposition with JSON_ARRAY format`
`146`	`146`	`returnJsonQueue(sea_result_data.data)`
`@@ -159,11 +159,11 @@ def __init__(self, data_array):`
`159`	`159`	`"""Initialize with JSON array data."""`
`160`	`160`	`self.data_array=data_array`
`161`	`161`	`self.cur_row_index=0`
`162`		`-self.n_valid_rows=len(data_array)`
	`162`	`+self.num_rows=len(data_array)`
`163`	`163`
`164`	`164`	`defnext_n_rows(self,num_rows):`
`165`	`165`	`"""Get the next n rows from the data array."""`
`166`		`-length=min(num_rows,self.n_valid_rows-self.cur_row_index)`
	`166`	`+length=min(num_rows,self.num_rows-self.cur_row_index)`
`167`	`167`	`slice=self.data_array[self.cur_row_index :self.cur_row_index+length]`
`168`	`168`	`self.cur_row_index+=length`
`169`	`169`	`returnslice`

`‎tests/unit/test_sea_queue.py‎`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ def test_init(self, sample_data):`
`30`	`30`	`queue=JsonQueue(sample_data)`
`31`	`31`	`assertqueue.data_array==sample_data`
`32`	`32`	`assertqueue.cur_row_index==0`
`33`		`-assertqueue.n_valid_rows==len(sample_data)`
	`33`	`+assertqueue.num_rows==len(sample_data)`
`34`	`34`
`35`	`35`	`deftest_next_n_rows_partial(self,sample_data):`
`36`	`36`	`"""Test fetching a subset of rows."""`
`@@ -82,7 +82,7 @@ def test_empty_data(self):`
`82`	`82`	`assertqueue.next_n_rows(10)== []`
`83`	`83`	`assertqueue.remaining_rows()== []`
`84`	`84`	`assertqueue.cur_row_index==0`
`85`		`-assertqueue.n_valid_rows==0`
	`85`	`+assertqueue.num_rows==0`
`86`	`86`
`87`	`87`
`88`	`88`	`classTestSeaResultSetQueueFactory:`
`@@ -130,7 +130,7 @@ def test_build_queue_with_inline_data(self, mock_sea_client, mock_description):`
`130`	`130`	`# Verify the queue is a JsonQueue with the correct data`
`131`	`131`	`assertisinstance(queue,JsonQueue)`
`132`	`132`	`assertqueue.data_array==data`
`133`		`-assertqueue.n_valid_rows==len(data)`
	`133`	`+assertqueue.num_rows==len(data)`
`134`	`134`
`135`	`135`	`deftest_build_queue_with_empty_data(self,mock_sea_client,mock_description):`
`136`	`136`	`"""Test building a queue with empty data."""`
`@@ -149,7 +149,7 @@ def test_build_queue_with_empty_data(self, mock_sea_client, mock_description):`
`149`	`149`	`# Verify the queue is a JsonQueue with empty data`
`150`	`150`	`assertisinstance(queue,JsonQueue)`
`151`	`151`	`assertqueue.data_array== []`
`152`		`-assertqueue.n_valid_rows==0`
	`152`	`+assertqueue.num_rows==0`
`153`	`153`
`154`	`154`	`deftest_build_queue_with_external_links(self,mock_sea_client,mock_description):`
`155`	`155`	`"""Test building a queue with external links raises NotImplementedError."""`

`‎tests/unit/test_sea_result_set.py‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -194,7 +194,7 @@ def test_init_with_result_data(self, result_set_with_data, sample_data):`
`194`	`194`	`# Verify the results queue was created correctly`
`195`	`195`	`assertisinstance(result_set_with_data.results,JsonQueue)`
`196`	`196`	`assertresult_set_with_data.results.data_array==sample_data`
`197`		`-assertresult_set_with_data.results.n_valid_rows==len(sample_data)`
	`197`	`+assertresult_set_with_data.results.num_rows==len(sample_data)`
`198`	`198`
`199`	`199`	`deftest_convert_json_types(self,result_set_with_data,sample_data):`
`200`	`200`	`"""Test the _convert_json_types method."""`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit31a0e52

File tree

3 files changed

3 files changed

`‎src/databricks/sql/utils.py‎`

`‎tests/unit/test_sea_queue.py‎`

`‎tests/unit/test_sea_result_set.py‎`

0 commit comments