- Notifications
You must be signed in to change notification settings - Fork843
feat: check snapshot timestamp when update table meta#19106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When yousign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Uh oh!
There was an error while loading.Please reload this page.
drmingdrmer left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@drmingdrmer reviewed 16 of 17 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on@dantengsky and@SkyFan2002)
Uh oh!
There was an error while loading.Please reload this page.
I hereby agree to the terms of the CLA available at:https://docs.databend.com/dev/policies/cla/
Summary
Ensure snapshot timestamp is not behind the table’s least visible time when updating table metadata
This PR adds a safety check during table metadata updates to verify that the snapshot timestamp is greater than or equal to the table’s least visible time (LVT).
This prevents newly referenced or committed snapshots from falling behind the vacuum boundary and being incorrectly reclaimed while vacuum is running.
Tests
Type of change
This change is