Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: check snapshot timestamp when update table meta#19106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
zhyass wants to merge1 commit intodatabendlabs:main
base:main
Choose a base branch
Loading
fromzhyass:feat_analyze

Conversation

@zhyass
Copy link
Member

@zhyasszhyass commentedDec 15, 2025
edited
Loading

I hereby agree to the terms of the CLA available at:https://docs.databend.com/dev/policies/cla/

Summary

Ensure snapshot timestamp is not behind the table’s least visible time when updating table metadata

This PR adds a safety check during table metadata updates to verify that the snapshot timestamp is greater than or equal to the table’s least visible time (LVT).
This prevents newly referenced or committed snapshots from falling behind the vacuum boundary and being incorrectly reclaimed while vacuum is running.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test -Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actionsgithub-actionsbot added the pr-featurethis PR introduces a new feature to the codebase labelDec 15, 2025
Copy link

@chatgpt-codex-connectorchatgpt-codex-connectorbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When yousign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Copy link
Member

@drmingdrmerdrmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@drmingdrmer reviewed 16 of 17 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status::shipit: complete! all files reviewed, all discussions resolved (waiting on@dantengsky and@SkyFan2002)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments

@drmingdrmerdrmingdrmerdrmingdrmer approved these changes

@dantengskydantengskyAwaiting requested review from dantengsky

@SkyFan2002SkyFan2002Awaiting requested review from SkyFan2002

Assignees

No one assigned

Labels

pr-featurethis PR introduces a new feature to the codebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zhyass@drmingdrmer

[8]ページ先頭

©2009-2025 Movatter.jp