Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Comments

add paging to file list#370

Open
joehand wants to merge 2 commits intomasterfrom
paged-file-list
Open

add paging to file list#370
joehand wants to merge 2 commits intomasterfrom
paged-file-list

Conversation

@joehand
Copy link
Contributor

Starts adding paging to file list. Depends onyo-fs PR. Currently looks like this:

screen shot 2017-01-11 at 12 19 10

Much style!

Notes:

  • I set the current page limit to 5 for easier testing. We can increase this before merging.
  • Has prev/next buttons to control paging.

TODO:

  • Merge yo-fs PR
  • Figure out how to style

@okdistribute
Copy link
Collaborator

okdistribute commentedFeb 23, 2017
edited
Loading

hey@joehand thanks for working on this ! Sorry it never moved forward.

As far as styling goes, it makes sense to me to leave it relatively unstyled in yo-fs to make sure that folks can restyle it as they please.

@Kriesse
Copy link
Contributor

@joehand@Karissa What's the status of this? Is just styling missing from it to be merged?

@joehand
Copy link
ContributorAuthor

We were waiting for the new hyperdrive, which is now out.This issue has a bit more discussion.

Part of the blocker was that the metadata download was too slow before. We are still fetching the whole metadata upfront, but this is probably fine now. To move forward I could:

  1. Update this PR and merge as is (with the full metadata fetch)
  2. Change to partial metadata fetching and update PR (bigger task, but better long-run)

@okdistribute
Copy link
Collaborator

Nice, thanks for circling back around on this@joehand ..
I'd say do the first one, and then open an issue for making it more efficient.

joehand reacted with thumbs up emoji

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joehand@okdistribute@Kriesse

[8]ページ先頭

©2009-2026 Movatter.jp