integrations/react/src/stable/lazyActivityPlugin.ts (2)

43-46:Consider using an enum for status constants

The status constants would be more maintainable and type-safe as an enum:

-const Uninitialized = -1;-const Pending = 0;-const Resolved = 1;-const Rejected = 2;+enum LazyStatus {+  Uninitialized = -1,+  Pending = 0,+  Resolved = 1,+  Rejected = 2,+}

Then update the type definitions to use the enum:

-type UninitializedPayload<T> = {-  _status: -1;+type UninitializedPayload<T> = {+  _status: LazyStatus.Uninitialized;

---

126-133:Add error logging for failed lazy loading

When lazy loading fails, the navigation is resumed but the error is silently swallowed. This could make debugging difficult.

       Activity._payload._result().then(         () => {           actions.resume();         },-        () => {+        (error) => {+          console.error(`Failed to load lazy activity "${actionParams.activityName}":`, error);           actions.resume();         },       );

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

integrations/react/src/stable/stackflow.tsx (1)

146-151:Normalize plugin flattening (DRY) and avoid Infinity-as-0 hack scattered inline

Current inline flatten/cast is duplicated (also used in addPlugin) and relies on a TS hack. Centralize into a helper to improve readability and reduce mistakes.

Apply this diff here:

-  const plugins: StackflowReactPlugin[] = [-    ...(options.plugins ?? [])-      .flat(Number.POSITIVE_INFINITY as 0)-      .map((p) => p as StackflowReactPlugin),-  ];+  const plugins: StackflowReactPlugin[] = normalizePlugins(options.plugins);

Add this helper (can be placed near the top ofstackflow() or file-level):

functionnormalizePlugins<TextendsBaseActivities>(entries:Array<StackflowPluginsEntry<T>>|undefined,):StackflowReactPlugin[]{return(entries??[]).flat(Number.POSITIVE_INFINITYas0).map((p)=>pasStackflowReactPlugin);}

Optionally, reuse the same helper inaddPlugin() to remove duplication.

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

integrations/react/src/stable/stackflow.tsx (1)

29-29:Tighten React gating to 18.x, prepend the plugin, and add radix to parseInt (optional dev warning)

Given the plugin depends on React internals, be conservative: only enable on 18.x, run it before user plugins (so pause executes early), and parse React version with radix 10. Optional: warn in dev when disabled.

- import { version } from "react";+ import { version as reactVersion } from "react";@@- const majorReactVersion = Number.parseInt(version);+ const majorReactVersion = Number.parseInt(reactVersion, 10);@@- /**-  * TODO: This plugin depends on internal APIs of React.-  * A proper solution (e.g. Suspense integration) should be implemented in the next major version.-  */- if (majorReactVersion >= 18 && majorReactVersion <= 19) {-   plugins.push(lazyActivityPlugin(activityComponentMap));- }+ /**+  * TODO: This plugin depends on internal React internals.+  * A proper solution (e.g., Suspense integration) should be implemented in the next major version.+  */+ if (majorReactVersion >= 18 && majorReactVersion < 19) {+   // Prepend so it can pause navigation before other plugins+   plugins.unshift(lazyActivityPlugin(activityComponentMap));+ } else if (process.env.NODE_ENV !== "production") {+   console.warn(+     `@stackflow/react: lazyActivityPlugin disabled (React ${reactVersion} not in supported range 18.x).`,+   );+ }

Also applies to: 152-161

integrations/react/src/stable/stackflow.tsx (1)

146-151:Simplify flattening and preserve generic typing for better type-safety

Theflat(Number.POSITIVE_INFINITY as 0) trick works but is a bit opaque and drops the generic parameter. Consider simplifying and keeping the generic to help TS catch mismatches.

-  const plugins: StackflowReactPlugin[] = [-    ...(options.plugins ?? [])-      .flat(Number.POSITIVE_INFINITY as 0)-      .map((p) => p as StackflowReactPlugin),-  ];+  const plugins: StackflowReactPlugin<NoInfer<T>>[] = [];+  (options.plugins ?? [])+    .flat(Infinity)+    .forEach((p) => {+      plugins.push(p as StackflowReactPlugin<NoInfer<T>>);+    });

Alternatively, extract a tiny helper for clarity:

functionnormalizePlugins<TextendsBaseActivities>(entries:Array<StackflowPluginsEntry<T>>,):StackflowReactPlugin<T>[]{return(entries.flat(Infinity)asunknownasStackflowReactPlugin<T>[]);}

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro