Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
/d3-geoPublic

Missing test coverage in src/clip/circle.js #213

Open
@martinfrances107

Description

@martinfrances107

I am slowly porting this module to rust...

The process has been made easy by the code qualify of this module.

  1. The tests are extensive.
  2. The design is good the code well laid out, modular and easy to read.

So please understand my next point is minor, and I do respect the overall quality.

When I have a issue I don't understand I insert console.log() statement to inspect variables...yes I use an IDE for complex debugging!!

but console.log() is good at showing which tests are covering the code under inspection.

my point is from the code below,no tests cover the tail of the file src/clip/circle.js... plenty of test cover the NULL that is return if the if statement takes no action but this complex if statement is not covered.

As I port my code .. I intend to push the new test upstream into this module.

But I am posting early just in case someone has a clear idea for a simple fix.

// Check that the first point is between a and b. if (meridian ? polar ? phi0 + phi1 > 0 ^ q[1] < (abs(q[0] - lambda0) < epsilon ? phi0 : phi1) : phi0 <= q[1] && q[1] <= phi1 : delta > pi ^ (lambda0 <= q[0] && q[0] <= lambda1)) { var q1 = cartesianScale(u, (-w + t) / uu); cartesianAddInPlace(q1, A); console.log("############################################### meridian output"); console.log([q, spherical(q1)]); console.log("############################################### meridian output"); debugger; return [q, spherical(q1)]; }

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions


      [8]ページ先頭

      ©2009-2025 Movatter.jp