- Notifications
You must be signed in to change notification settings - Fork3.4k
chore: Refactor {launch} from@packages/launcher#32687
Draft
cacieprins wants to merge 10 commits intodevelopfrom
Draft
chore: Refactor {launch} from@packages/launcher#32687cacieprins wants to merge 10 commits intodevelopfrom
@packages/launcher#32687cacieprins wants to merge 10 commits intodevelopfrom
Conversation
6e623b6 toc238b66Compare| debug('launching browser %o', { browser, url }) | ||
| // We shouldn't need to check this, because FoundBrowser.path is | ||
| // not optional. |
ContributorAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Lots of places explicitly coerce unknown POJOs toFoundBrowser, though, so it's important to keep it
| import { removeDuplicateBrowsers } from '@packages/data-context/src/sources/BrowserDataSource' | ||
| import { knownBrowsers } from './known-browsers' | ||
| import * as darwinHelper from './darwin' | ||
| import * as darwinHelper from './darwinHelpers' |
ContributorAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
These were renamed because intellisense was complaining that
/lib/darwin/index.ts was too similar to/lib/platforms/Darwin.ts 🤷
cypressbot commentedOct 14, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
cypress | ||||||||||||||||||||||||||||||||||||||||
| Project | cypress |
| Branch Review | chore/launcher-launch-refactor |
| Run status | |
| Run duration | 19m 31s |
| Commit | |
| Committer | Cacie Prins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 Failures | 0 |
 Flaky | 12 |
 Pending | 1098 |
 Skipped | 4 |
 Passing | 26694 |
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage 45.48% | |
|---|---|
| Untested elements | 188 |
| Tested elements | 161 |
Accessibility 97.99% | |
|---|---|
| Failed rules | 4 critical 8 serious 2 moderate 2 minor |
| Failed elements | 101 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional details
Browser process spawning was a little unwieldy. This applies the stranger fig pattern by:
packages/launcher/lib/launch.ts(renamed frombrowsers.tsto match its export) that focus on its side effects rather than implementationSeveral of the platform classes are empty as placeholders for browser detection logic, and should be expanded as strangler fig is applied to
detectanddetectByPath. Once the public interface here is strangled, we should consider whether the public interface for@packages/launcherstill fits its requirements, or if there are better patterns to expose.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?