Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Cw2-18 Improve Semantic HTML#7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
derekxu04 merged 7 commits intomasterfromCW2-18_Improve_Semantic_HTML
Apr 18, 2024

Conversation

@QuadAces
Copy link
Contributor

Why the changes are required?

For SEO & Accessibility

Changes

  • Made it so that the site only has one h1 tag for SEO
  • Made it so that images/icons have an alt tag for accessibility

Screenshots

No UI changes

Comments

No comments

@QuadAcesQuadAces changed the titleCw2 18 Improve Semantic HTMLCw2-18 Improve Semantic HTMLApr 11, 2024
* added events template* removed section* modified events to coordinate with navbar on click---------Co-authored-by: Stuart Cutbush <stuart@Stuarts-MacBook-Pro.local>Co-authored-by: Derek Xu <xuderek2004@gmail.com>
Copy link
Contributor

@derekxu04derekxu04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Cool, not too complicated.

Just make sure the pipeline is passing, will only take a second, you can runnpm run lint:fix for example for automatic linting

@QuadAces
Copy link
ContributorAuthor

Alrighty, should work now, prettier just wanted the code formatted :P

Copy link
Contributor

@derekxu04derekxu04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

lgtm

@derekxu04derekxu04 merged commit229c00e intomasterApr 18, 2024
@derekxu04derekxu04 deleted the CW2-18_Improve_Semantic_HTML branchApril 18, 2024 07:21
PenTest-duck pushed a commit that referenced this pull requestMay 30, 2024
* changed the h1 tags* changed image alt tags* changed tailwind* CW2-3 Add events section (#4)* added events template* removed section* modified events to coordinate with navbar on click---------Co-authored-by: Stuart Cutbush <stuart@Stuarts-MacBook-Pro.local>Co-authored-by: Derek Xu <xuderek2004@gmail.com>* changes to make linter approve* formatted code?---------Co-authored-by: Stuart Cutbush <stuart@Stuarts-MacBook-Pro.local>Co-authored-by: Derek Xu <xuderek2004@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@derekxu04derekxu04derekxu04 requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@QuadAces@derekxu04

[8]ページ先頭

©2009-2025 Movatter.jp