Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

CW2-3 Add events section#4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
derekxu04 merged 5 commits intomasterfromCW2-3_Add_Events_Section
Apr 12, 2024
Merged

Conversation

@QuadAces
Copy link
Contributor

@QuadAcesQuadAces commentedApr 4, 2024
edited
Loading

Why the changes are required?

To add an events section with content

Changes

  • Changed events component with the same text as the old website
  • Added a placeholder for potential events images

Screenshots

Screenshot 2024-04-04 at 7 20 45 pm### Comments- Is not fit for deployment, will require the Facebook API/events to replace the "placeholder"

Copy link
Contributor

@derekxu04derekxu04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good!

Just one quick change:

Could you ensure that clicking the sections on the navbar at the top scrolls to the relevant section

QuadAces reacted with thumbs up emoji
Copy link
Contributor

@derekxu04derekxu04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

lgtm

@derekxu04derekxu04 merged commit3fa4d93 intomasterApr 12, 2024
@derekxu04derekxu04 deleted the CW2-3_Add_Events_Section branchApril 12, 2024 14:00
derekxu04 added a commit that referenced this pull requestApr 18, 2024
* changed the h1 tags* changed image alt tags* changed tailwind* CW2-3 Add events section (#4)* added events template* removed section* modified events to coordinate with navbar on click---------Co-authored-by: Stuart Cutbush <stuart@Stuarts-MacBook-Pro.local>Co-authored-by: Derek Xu <xuderek2004@gmail.com>* changes to make linter approve* formatted code?---------Co-authored-by: Stuart Cutbush <stuart@Stuarts-MacBook-Pro.local>Co-authored-by: Derek Xu <xuderek2004@gmail.com>
PenTest-duck pushed a commit that referenced this pull requestMay 30, 2024
* added events template* removed section* modified events to coordinate with navbar on click---------Co-authored-by: Stuart Cutbush <stuart@Stuarts-MacBook-Pro.local>Co-authored-by: Derek Xu <xuderek2004@gmail.com>
PenTest-duck pushed a commit that referenced this pull requestMay 30, 2024
* changed the h1 tags* changed image alt tags* changed tailwind* CW2-3 Add events section (#4)* added events template* removed section* modified events to coordinate with navbar on click---------Co-authored-by: Stuart Cutbush <stuart@Stuarts-MacBook-Pro.local>Co-authored-by: Derek Xu <xuderek2004@gmail.com>* changes to make linter approve* formatted code?---------Co-authored-by: Stuart Cutbush <stuart@Stuarts-MacBook-Pro.local>Co-authored-by: Derek Xu <xuderek2004@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@derekxu04derekxu04derekxu04 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@QuadAces@derekxu04

[8]ページ先頭

©2009-2025 Movatter.jp