Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

CW2-5 Sponsors Page Draft/Template#3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
andrew-l3 merged 3 commits intomasterfromCW2-5-Create-sponsors-page
Apr 11, 2024

Conversation

@andrew-l3
Copy link
Contributor

@andrew-l3andrew-l3 commentedApr 2, 2024•
edited by atlassianbot
Loading

CMS-299 A brief summary of the ticket

Why the changes are required?

Creation of the sponsors subpage. A simple template at this stage, containing the current sponsor list (from the mainpage) and categorised as listed. Styling and general theme to be changed in the future.

Changes

Completed the following:

  • Added all current sponsor logos as svgs.
  • “View our sponsors” button should redirect to a sponsors page.
  • For now can just show the logos and clicking should redirect to the company’s website.
  • Navbar logo redirects to mainpage (instead of anchor tag).
  • Footer component separated and created.

Screenshots

sponsors-page

Comments

Links have been obtained from each sponsor's main webpage (further confirmation required). Logos have been obtained from google drive where possible (otherwise from the active main site). Logo's have not been filtered at this stage (i.e. further guidelines are required to proceed).

Copy link
Contributor

@derekxu04derekxu04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good!

Suggestions:

  • I don't really like the background they've used for the sponsors card, also they seem to have used all white company logos, it is fine to leave as now if we want to come back and choose a specific look later
  • Adding a sponsorInfo (or similar) type todata.ts

Changes:

  • Clicking "resources" > clicking "about us" doesn't work
    • this is annoying because some sections direct to sections on landing page vs sponsors to its own separate page, I think we just end up making pages for each section but to be confirmed
  • "View our sponsors" button on main landing page does not redirect to sponsors page
  • Change the "C:\INTERNAL STRUCTURE" text depending on which page we are on

Copy link
Contributor

@derekxu04derekxu04 left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

I've merged master and made a small changes todata.ts and some other files for linting purposes.@andrew-l3 if my changes look all good happy for you to merge

@andrew-l3andrew-l3 merged commit1777609 intomasterApr 11, 2024
PenTest-duck pushed a commit that referenced this pull requestMay 30, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@derekxu04derekxu04derekxu04 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrew-l3@derekxu04
[8]ページ先頭
©2009-2025 Movatter.jp