NotificationsYou must be signed in to change notification settings
Fork1.2k
Star14.1k

Make SecretServiceKeychainAccess the default selection#4025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

purejava wants to merge1 commit intocryptomator:develop

base:develop

Choose a base branch

frompurejava:new-secret-service

Open

Make SecretServiceKeychainAccess the default selection#4025

purejava wants to merge1 commit intocryptomator:developfrompurejava:new-secret-service

Conversation

Copy link

Contributor

purejava commentedOct 27, 2025

Completescryptomator/integrations-linux#125

Make SecretServiceKeychainAccess the default selection

9a74194

Copy link

coderabbitaibot commentedOct 27, 2025

Walkthrough

The pull request updates the Linux default keychain provider in Settings.java from GnomeKeyringKeychainAccess to SecretServiceKeychainAccess. The Windows and macOS default keychain providers remain unchanged. No public API signatures were modified.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Single-file change with focused, targeted modification to a configuration default
Minimal code footprint with low risk of unintended side effects
Consider verifying that SecretServiceKeychainAccess is properly implemented and available for Linux platforms

Possibly related PRs

Bump integrations-libs to api level 1.6.0 #3877: Updates keychain APIs and implementations; directly relevant as this PR changes which keychain provider is used by default on Linux.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run`@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The pull request title "Make SecretServiceKeychainAccess the default selection" directly and accurately describes the main change in the changeset. According to the raw summary, the modification changes the Linux default keychain provider from GnomeKeyringKeychainAccess to SecretServiceKeychainAccess, which precisely matches what the title communicates. The title is concise, clear, and specific enough that a teammate reviewing history would immediately understand the primary change without ambiguity.
Description Check	✅ Passed	The pull request description "Completescryptomator/integrations-linux#125" is related to the changeset, as it references completing work on Linux keychain integration which aligns with the Linux-specific default keychain provider change. While the description is minimal and brief, it provides meaningful context by linking to related work in the integrations-linux repository rather than being completely generic or off-topic.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and betweende4c7d4 and9a74194.

📒 Files selected for processing (1)

src/main/java/org/cryptomator/common/settings/Settings.java (1 hunks)

🔇 Additional comments (1)

src/main/java/org/cryptomator/common/settings/Settings.java (1)
49-49:Change looks correct, but depends on fixing the migration logic.
The update to useSecretServiceKeychainAccess as the Linux default aligns with the PR objectives. However, this change will not work as intended until the conflicting migration logic (lines 156-158) is addressed.

Thanks for usingCodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment@coderabbitai help to get the list of available commands and usage tips.}