forked fromCylix/cpp_redis
- Notifications
You must be signed in to change notification settings - Fork209
Base classes should have virtual destructors#55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Fromhttps://en.cppreference.com/w/cpp/language/destructor ...Virtual destructorsDeleting an object through pointer to base invokes undefined behavior unless the destructor in the base class is virtual:class Base { public: virtual ~Base() {}};class Derived : public Base {};Base* b = new Derived;delete b; // safeA common guideline is that a destructor for a base class must be either public and virtual or protected and nonvirtualPrevents errors like the following:INFO: From Compiling external/com_github_cpp_redis_cpp_redis/sources/core/types.cpp:In file included from external/com_github_cpp_redis_cpp_redis/sources/core/types.cpp:23:In file included from bazel-out/darwin-fastbuild/bin/external/com_github_cpp_redis_cpp_redis/_virtual_includes/cpp_redis/cpp_redis/core/types.hpp:26:In file included from /Library/Developer/CommandLineTools/usr/include/c++/v1/string:500:In file included from /Library/Developer/CommandLineTools/usr/include/c++/v1/string_view:176:In file included from /Library/Developer/CommandLineTools/usr/include/c++/v1/__string:56:In file included from /Library/Developer/CommandLineTools/usr/include/c++/v1/algorithm:644:/Library/Developer/CommandLineTools/usr/include/c++/v1/memory:1880:58: warning: destructor called on non-final 'cpp_redis::xmessage' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] _LIBCPP_INLINE_VISIBILITY void destroy(pointer __p) {__p->~_Tp();} ^
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fromhttps://en.cppreference.com/w/cpp/language/destructor ...
Virtual destructors
Deleting an object through pointer to base invokes undefined behavior unless the destructor in the base class is virtual:
class Base {
public:
virtual ~Base() {}
};
class Derived : public Base {};
Base* b = new Derived;
delete b; // safe
A common guideline is that a destructor for a base class must be either public and virtual or protected and nonvirtual
Prevents errors like the following:
INFO: From Compiling external/com_github_cpp_redis_cpp_redis/sources/core/types.cpp:
In file included from external/com_github_cpp_redis_cpp_redis/sources/core/types.cpp:23:
In file included from bazel-out/darwin-fastbuild/bin/external/com_github_cpp_redis_cpp_redis/_virtual_includes/cpp_redis/cpp_redis/core/types.hpp:26:
In file included from /Library/Developer/CommandLineTools/usr/include/c++/v1/string:500:
In file included from /Library/Developer/CommandLineTools/usr/include/c++/v1/string_view:176:
In file included from /Library/Developer/CommandLineTools/usr/include/c++/v1/__string:56:
In file included from /Library/Developer/CommandLineTools/usr/include/c++/v1/algorithm:644:
/Library/Developer/CommandLineTools/usr/include/c++/v1/memory:1880:58: warning: destructor called on non-final 'cpp_redis::xmessage' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
_LIBCPP_INLINE_VISIBILITY void destroy(pointer __p) {__p->~_Tp();}
^