Commit147c589

agasparovic-sabre

authored and

appkins

committed

Base classes should have virtual destructors (#55)

Fromhttps://en.cppreference.com/w/cpp/language/destructor ...Virtual destructorsDeleting an object through pointer to base invokes undefined behavior unless the destructor in the base class is virtual:class Base { public: virtual ~Base() {}};class Derived : public Base {};Base* b = new Derived;delete b; // safeA common guideline is that a destructor for a base class must be either public and virtual or protected and nonvirtualPrevents errors like the following:INFO: From Compiling external/com_github_cpp_redis_cpp_redis/sources/core/types.cpp:In file included from external/com_github_cpp_redis_cpp_redis/sources/core/types.cpp:23:In file included from bazel-out/darwin-fastbuild/bin/external/com_github_cpp_redis_cpp_redis/_virtual_includes/cpp_redis/cpp_redis/core/types.hpp:26:In file included from /Library/Developer/CommandLineTools/usr/include/c++/v1/string:500:In file included from /Library/Developer/CommandLineTools/usr/include/c++/v1/string_view:176:In file included from /Library/Developer/CommandLineTools/usr/include/c++/v1/__string:56:In file included from /Library/Developer/CommandLineTools/usr/include/c++/v1/algorithm:644:/Library/Developer/CommandLineTools/usr/include/c++/v1/memory:1880:58: warning: destructor called on non-final 'cpp_redis::xmessage' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] _LIBCPP_INLINE_VISIBILITY void destroy(pointer __p) {__p->~_Tp();} ^

1 parent53e6112 commit147c589Copy full SHA for 147c589

File tree

1 file changed

-0

lines changed

includes/cpp_redis/impl
- types.hpp

1 file changed

-0

lines changed

`‎includes/cpp_redis/impl/types.hpp‎`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -40,6 +40,8 @@ namespace cpp_redis {`
`40`	`40`	`classserializer_type {`
`41`	`41`	`public:`
`42`	`42`	`inlineserializer_type() {}`
	`43`	`+`
	`44`	`+virtual~serializer_type() {}`
`43`	`45`
`44`	`46`	`/**`
`45`	`47`	`* @return the underlying string`
`@@ -62,6 +64,8 @@ typedef std::shared_ptr<serializer_type> serializer_ptr_t;`
`62`	`64`	`template<typename T>`
`63`	`65`	`classmessage_impl {`
`64`	`66`	`public:`
	`67`	`+virtual~message_impl() {}`
	`68`	`+`
`65`	`69`	`virtualconst std::stringget_id()const = 0;`
`66`	`70`
`67`	`71`	`virtualconst message_impl&set_id(std::string id) = 0;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit147c589

File tree

1 file changed

1 file changed

`‎includes/cpp_redis/impl/types.hpp‎`

0 commit comments