- Notifications
You must be signed in to change notification settings - Fork4
A minimal std::expected<T, E>#12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
deanberris wants to merge6 commits intocpp-netlib:mainChoose a base branch fromdeanberris:topic/simple-connection
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Open
Changes fromall commits
Commits
Show all changes
6 commits Select commitHold shift + click to select a range
d3fffac Work In Progress: A minimal std::expected<T, E>
deanberris4b7c4d9 fixup: Add error() observer
deanberrisbf4bd0b fixup: Add operator* observers
deanberris411094e fixup: Add operator-> and additional observers
deanberrisb2dd56e fixup: add some assignment implementations.
deanberrise9ae15c fixup: add more test cases for assignment, fix default construction
deanberrisFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
6 changes: 6 additions & 0 deletions.clang-format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| BasedOnStyle: Google | ||
| --- | ||
| Language: Cpp | ||
| DerivePointerAlignment: false | ||
| PointerAlignment: Left |
30 changes: 30 additions & 0 deletionsCMakeLists.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| # Copyright 2019 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| cmake_minimum_required(VERSION 3.13) | ||
| enable_testing() | ||
| find_package(GTest MODULE REQUIRED) | ||
| # Include directories accessible from here. | ||
| include_directories(.) | ||
| # Require C++17 with no extensions. | ||
| set(CMAKE_CXX_STANDARD 17) | ||
| set(CMAKE_CXX_STANDARD_REQUIRED ON) | ||
| set(CMAKE_CXX_EXTENSIONS OFF) | ||
| # Add the test to the std::expected implementation. | ||
| add_executable(expected_test netlib/expected_test.cc) | ||
| target_link_libraries(expected_test PRIVATE GTest::GTest GTest::Main) | ||
| add_test(expected_test expected_test) |
29 changes: 29 additions & 0 deletionsnetlib/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # netlib Directory | ||
| This is the main source directory for the project. The intent is to keep this | ||
| directory flat with subdirectories for logical groupings. This means all the | ||
| headers, implementation, and test code should be co-hosted in this directory. | ||
| ## Structure | ||
| All implementation files must end with the `.cc` filename extension, and all | ||
| headers must end in `.h`. If we have a file named `connection.cc` the header | ||
| must be `connection.h` and the test(s) should be in `connection_test.cc`. | ||
| We shall control the installed headers through our CMake configuration | ||
| instead of assuming that all headers are publicly accessible. When including | ||
| files, we should always include headers in the netlib repository by relative | ||
| inclusion with the `netlib/` directory (based off the root of the | ||
| repository). As an example: | ||
| ```c++ | ||
| // In connection.cc and connection_test.cc. | ||
| #include "netlib/connection.h" | ||
| ``` | ||
| ## Subdirectories | ||
| We can introduce subdirectories for logical grouping, each one following the | ||
| same structure rules as described here. For instance, if we have a | ||
| subdirectory of encoding/decoding, we can introduce a `coding/` subdirectory | ||
| with all the encoders and decoders implemented. |
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.