Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Explicitely set boost namespace when using make_optional.#880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

maingoh
Copy link

@maingohmaingoh commentedSep 16, 2019
edited
Loading

Following#869

Avoid conflicting withstd::make_optional from c++17 (g++7.4.0).

/usr/include/boost/network/protocol/http/message/async_message.hpp:100:24: error: no match for 'operator=' (operand types are 'boost::optional<std::multimap<std::__cxx11::basic_string<char>, std::__cxx11::basic_string<char>, boost::network::impl::is_less_ignore_case_impl> >' and 'std::optional<std::multimap<std::__cxx11::basic_string<char>, std::__cxx11::basic_string<char>, boost::network::impl::is_less_ignore_case_impl> >')     retrieved_headers_ = make_optional(raw_headers);

Probablyoptional should also be replaced byboost::optional, but in my case it was enough for the compiler to deduce the types.

@maingoh
Copy link
Author

Tests are not passing for some reason ?

@maingoh
Copy link
Author

@deanberris any plan to merge this ? I would prefer to rely on the official repository than my own fork :)

@glynos
Copy link
Member

The CI failures are not caused by the changes in the commit.

LGTM

maingoh reacted with thumbs up emoji

@glynosglynos merged commit2b8406e intocpp-netlib:0.13-releaseOct 4, 2019
@maingohmaingoh deleted the set_namespace_make_optional branchOctober 4, 2019 10:10
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@maingoh@glynos

[8]ページ先頭

©2009-2025 Movatter.jp