forked fromglynos/cpp-netlib
- Notifications
You must be signed in to change notification settings - Fork425
Explicitely set boost namespace when using make_optional.#880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
glynos merged 1 commit intocpp-netlib:0.13-releasefrommaingoh:set_namespace_make_optionalOct 4, 2019
Merged
Explicitely set boost namespace when using make_optional.#880
glynos merged 1 commit intocpp-netlib:0.13-releasefrommaingoh:set_namespace_make_optionalOct 4, 2019
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…icting with std::make_optional from c++17
Tests are not passing for some reason ? |
@deanberris any plan to merge this ? I would prefer to rely on the official repository than my own fork :) |
The CI failures are not caused by the changes in the commit. LGTM |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Following#869
Avoid conflicting with
std::make_optional
from c++17 (g++7.4.0).Probably
optional
should also be replaced byboost::optional
, but in my case it was enough for the compiler to deduce the types.