NotificationsYou must be signed in to change notification settings
Fork425
Star2k

Fix for boost 1.70 (get_io_service() was deprecated and was removed)#878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

deanberris merged 6 commits intocpp-netlib:0.13-releasefromenricodetoma:0.13-release

Aug 12, 2019

Merged

Fix for boost 1.70 (get_io_service() was deprecated and was removed)#878

deanberris merged 6 commits intocpp-netlib:0.13-releasefromenricodetoma:0.13-release

Aug 12, 2019

Conversation

Copy link

enricodetoma commentedAug 6, 2019

get_io_service() was removed in Boost 1.70.

I made a pull request using the alternativeget_executor().context()

enricodetoma added3 commits

August 6, 2019 08:00

Fix for boost 1.70 (get_io_service() was deprecated and was removed)

dfaa858

Fix for boost 1.70 (get_io_service() was deprecated and was removed)

cf11364

Fix for boost 1.70 (get_io_service() was deprecated and was removed)

5351fc6

Copy link

Author

enricodetoma commentedAug 8, 2019

I forgot to keep compatibility with older ASIO versions. Now the pull request should be ok.

enricodetoma mentioned this pull request

Aug 8, 2019

Does not compile with Boost 1.70 and newer#875

Open

deanberris requested changes

Aug 8, 2019

View reviewed changes

Copy link

Member

deanberris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks,@enricodetoma!

Please find comments below.

boost/network/protocol/http/client/connection/async_base.hpp OutdatedShow resolvedHide resolved

Fix for boost 1.70 (get_io_service() was deprecated and was removed)

9aaa546

deanberris requested changes

Aug 9, 2019

View reviewed changes

Copy link

Member

deanberris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Couple more requests and I think we're almost there... :)

boost/network/compat.hpp OutdatedShow resolvedHide resolved

Fix for boost 1.70 (get_io_service() was deprecated and was removed)

77adf2d

deanberris requested changes

Aug 9, 2019

View reviewed changes

boost/network/protocol/http/client/connection/connection_delegate_factory.hpp OutdatedShow resolvedHide resolved

Fix for boost 1.70 (get_io_service() was deprecated and was removed)

227f552

deanberris approved these changes

Aug 12, 2019

View reviewed changes

Copy link

Member

deanberris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for this,@enricodetoma!

deanberris merged commit2bef8be intocpp-netlib:0.13-release

Aug 12, 2019

yogev-lb added a commit to LightBitsLabs/osmosis that referenced this pull request

Mar 23, 2023

upgrade cpp-netlib to work with boost>1.70

f65d8e2

using the following patch:cpp-netlib/cpp-netlib#878to update support for new boost.

Labels

None yet

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix for boost 1.70 (get_io_service() was deprecated and was removed)#878

Fix for boost 1.70 (get_io_service() was deprecated and was removed)#878

Uh oh!

Conversation

enricodetoma commentedAug 6, 2019

Uh oh!

enricodetoma commentedAug 8, 2019

Uh oh!

deanberris left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

deanberris left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

deanberris left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants