Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix issue with Microsoft's checked iterators#852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

LoopinFool
Copy link

After grabbing the latest 0.13-release to sync up with Boost 1.67, I ran into a big issue in my debug build.
I constantly hit an assert in the checked iterators so had to track it down and fix it.
The current code casts iterators from the partial_parsed buffer (which can be quite large) to iterators for the small temporary std::array buffer. MS implemented their checked iterators using the statically-declared size of the array (which is much smaller than partial_parsed) so they hit all the time.

Also, that static_cast likely only worked because compilers likely use char* as the iterator type for both containers, but I don't think assuming that is portable.

I changed chunk_encoding_parser so that its operator() and update_chunk_size can take any compatible iterator_range type as arguments.

… Avoids an issue with Microsoft's checked iterators and is likely more correct/portable.
@deanberris
Copy link
Member

LGTM -- thanks@LoopinFool!

@deanberrisdeanberris merged commitca95f04 intocpp-netlib:0.13-releaseJul 19, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@LoopinFool@deanberris

[8]ページ先頭

©2009-2025 Movatter.jp