- Notifications
You must be signed in to change notification settings - Fork425
Update Travis Configuration#848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Hi@glynos -- we're currently finding build breakages in the URI library in master, with the use of C++14 features. I'm not sure whether we just need to update the master submodule, but I'd like to see this change merged (and then get us back to 'green' on the CI dashboard). Thanks in advance! |
@deanberris are you asking to disable the C++ features from uri? I can take a look later this weekend. |
I think, maybe either that we need to stick to C++11 for master (until we decide to consciously move to C++14), to address issues like these: Note that the Travis builds are now half-green (clang builds work just fine but the GCC builds complain about the constexpr warning). |
@deanberris try now with the tip of master |
Thanks@glynos -- I think the problem is the code, in that it's actually using an if statement. Let me send you a PR to try and address that specific issue. |
4a6fbe4 toe056ad2CompareRebased on top of the new URI tip of master, now running the checks through the travis config. |
Hi@glynos -- I'm seeing this issue with the latest in the URI library: I've updated the latest commit in cpp-netlib's master branch to be the tip of the uri library's master, and this error looks really suspicious to me. We're attempting to build with clang-3.8 with libstdc++ as the standard library, which I know is a supported use-case in the past. Thoughts? |
It's obviously a configuration error. Are you sure that the header path is the appropriate one? IIUC, FWIW, I am using clang 3.8 on MacOS it builds with no errors. |
Yeah, I should have said this is in the Travis CI -- you can see the results here: https://travis-ci.org/cpp-netlib/cpp-netlib/jobs/393936085 Note that Travis does this from scratch all the time, and we're using the clang-3.8 package from the LLVM repository. |
Why do you want to support GCC 4.8? |
I can test it locally using GCC 4.8 and 5, and with no issues. |
And with clang 3.9 |
They're all fine, except for clang 3.8 -- which is what's currently failing. GCC 4.8 is still the default compiler for some of the LTS releases. |
I found the error. Try again using the tip of the uri/master. |
This change allows us to get more compilers and eventually moreplatforms being tested.
3d2dd20 to61b166fCompareLGTM |
This change makes the build matrix explicit, and allows us to upgrade the CI infrastructure to use:
In the future, we can also test on OS X and start retiring support for older compilers when we start moving to using C++14 features in the library.