- Notifications
You must be signed in to change notification settings - Fork425
fix client_get_streaming_test#840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Changes from2 commits
16c1619adb024ac1702e3a9904faFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -38,8 +38,10 @@ if (Boost_FOUND) | ||
| client_get_test | ||
| client_get_different_port_test | ||
| # client_get_timeout_test | ||
| client_get_ready_test) | ||
| if (OPENSSL_FOUND) | ||
| list(APPEND TESTS client_get_streaming_test) | ||
| endif() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I don't think this is what I meant. The | ||
| foreach ( test ${TESTS} ) | ||
| add_executable(cpp-netlib-http-${test} ${test}.cpp) | ||
| add_dependencies(cpp-netlib-http-${test} cppnetlib-uri | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -26,7 +26,7 @@ struct body_handler { | ||
| TYPED_TEST_CASE(HTTPClientTest, ClientTypes); | ||
| TYPED_TEST(HTTPClientTest, GetStreamingTest) { | ||
| typename TypeParam::request request("https://www.boost.org"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Thanks,@yhager -- we probably want to only build this particular test now if we've enabled HTTPS support. Can you try making this whole test conditional on whether the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. This should be much simpler to do: #if BOOST_NETWORK_ENABLE_HTTPSTYPED_TEST(HTTPClientTest, GetStreamingTest) {...}#endif There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. No problem. Pushed the change you requested. Sorry for misunderstanding what you meant. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. All good, thanks! | ||
| typename TypeParam::response response; | ||
| typename TypeParam::string_type body_string; | ||
| typename TypeParam::string_type dummy_body; | ||