- Notifications
You must be signed in to change notification settings - Fork425
fix client_get_streaming_test#840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -26,7 +26,7 @@ struct body_handler { | |||
| TYPED_TEST_CASE(HTTPClientTest, ClientTypes); | |||
| TYPED_TEST(HTTPClientTest, GetStreamingTest) { | |||
| typename TypeParam::request request("http://www.boost.org"); | |||
| typename TypeParam::request request("https://www.boost.org"); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks,@yhager -- we probably want to only build this particular test now if we've enabled HTTPS support. Can you try making this whole test conditional on whether theBOOST_NETWORK_ENABLE_HTTPS macro is defined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This should be much simpler to do:
#if BOOST_NETWORK_ENABLE_HTTPSTYPED_TEST(HTTPClientTest, GetStreamingTest) {...}#endif
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No problem. Pushed the change you requested. Sorry for misunderstanding what you meant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
All good, thanks!
| client_get_ready_test) | ||
| if (OPENSSL_FOUND) | ||
| list(APPEND TESTS client_get_streaming_test) | ||
| endif() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't think this is what I meant.
Theclient_get_streaming_test could have just skipped building theGetStreamingTest by checking whether theBOOST_NETWORK_ENABLE_HTTPS as a preprocessor macro. Please revert this part of the PR.
| @@ -26,7 +26,7 @@ struct body_handler { | |||
| TYPED_TEST_CASE(HTTPClientTest, ClientTypes); | |||
| TYPED_TEST(HTTPClientTest, GetStreamingTest) { | |||
| typename TypeParam::request request("http://www.boost.org"); | |||
| typename TypeParam::request request("https://www.boost.org"); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This should be much simpler to do:
#if BOOST_NETWORK_ENABLE_HTTPSTYPED_TEST(HTTPClientTest, GetStreamingTest) {...}#endif
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM -- thanks@yhager!
| @@ -26,7 +26,7 @@ struct body_handler { | |||
| TYPED_TEST_CASE(HTTPClientTest, ClientTypes); | |||
| TYPED_TEST(HTTPClientTest, GetStreamingTest) { | |||
| typename TypeParam::request request("http://www.boost.org"); | |||
| typename TypeParam::request request("https://www.boost.org"); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
All good, thanks!
* fix client_get_streaming_test* perform client_get_streaming_test only if SSL is enabled* test for BOOST_NETWORK_ENABLE_HTTPS for https streaming test
fixes#836