- Notifications
You must be signed in to change notification settings - Fork425
RFC: Pull out status_t to the top level to allow using those enum values from clients.#837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks@igorpeshansky -- I love this idea. We might even be able to consolidate this with the server-side defined status codes as well. Feedback follows.
| namespace http { | ||
| /// The set of known status codes for HTTP server responses. | ||
| enum status_t { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If we're doing this, then I suggest dropping the_t suffix, and calling itstatus_code to be more descriptive.
Also, if we're going to do this as well, we might as well add the following:
- An "unknown" value to be the default (say,
0). - More known status codes, even those that are extensions -- we can probably do those later on, instead of in this PR.
| @@ -0,0 +1,39 @@ | |||
| #ifndef BOOST_NETWORK_PROTOCOL_HTTP_STATUS_HPP_20180501 | |||
| #define BOOST_NETWORK_PROTOCOL_HTTP_STATUS_HPP_20180501 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Consider naming this filestatus_code.hpp along with the suggested change to the enum name.
anonimal commentedMay 1, 2018
@igorpeshansky can you also PR this to branch 0.13-release? |
@deanberris PTAL. Would like to gauge if this change is actually a good idea.