Jan 26, 2018 · Jan 13, 2018 · Jan 13, 2018 · Jan 20, 2018 · Jan 23, 2018 · Jan 19, 2018
diff --git a/libs/network/example/http/async_server_file_upload.cpp b/libs/network/example/http/async_server_file_upload.cpp
    /// @param [in] conn Connection object
    ///
    void operator()(server::request const& req, const server::connection_ptr& conn) {
 staticstd::map<std::string, std::string> headers = {
        std::map<std::string, std::string> headers = {
            {"Connection","close"},
            {"Content-Length", "0"},
            {"Content-Type", "text/plain"}
                conn->write(err);
            }
        } else {
            staticstd::stringbody("Only path allowed is /upload");
            headers["Content-Length"] = std::to_string(body.size());
            staticconstexpr charbody[] ="Only path allowed is /upload";
            headers["Content-Length"] = std::to_string(sizeof(body));
            conn->set_status(server::connection::bad_request);
            conn->set_headers(headers);
            conn->write(body);
diff --git a/libs/network/example/http/hello_world_async_server_with_work_queue.cpp b/libs/network/example/http/hello_world_async_server_with_work_queue.cpp
      // some heavy work!
      std::this_thread::sleep_for(std::chrono::seconds(10));

 staticstd::map<std::string, std::string> headers = {
      std::map<std::string, std::string> headers = {
        {"Content-Length", "0"},
        {"Content-Type", "text/plain"},
      };
diff --git a/libs/network/example/http/hello_world_server.cpp b/libs/network/example/http/hello_world_server.cpp
    std::ostringstream data;
    data << "Hello, " << ip << ':' << port << '!';

 staticstd::map<std::string, std::string> headers = {
    std::map<std::string, std::string> headers = {
      {"Content-Length", "0"},
      {"Content-Type", "text/plain"},
    };
Original file line number	Diff line number	Diff line change
Expand Up		@@ -189,7 +189,7 @@ struct connection_handler {
		/// @param [in] conn Connection object
		///
		void operator()(server::request const& req, const server::connection_ptr& conn) {
		staticstd::map<std::string, std::string> headers = {
		std::map<std::string, std::string> headers = {
		{"Connection","close"},
		{"Content-Length", "0"},
Copy link Member deanberrisJan 19, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Why do you need this? Copy link Author carunJan 19, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. This was the reason for#681 Copy link Member deanberrisJan 23, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I think I understand now, that you want to always define this for every new response. That makes sense. Copy link Member deanberrisJan 23, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I think this map really ought to not be static, unless you're going to make copies of it for every instance of this handler -- note that there could be multiple threads accessing this map, and updating it on the fly will cause all sorts of threading issues. Aside from that, the other changes look good.
		{"Content-Type", "text/plain"}
Expand DownExpand Up		@@ -225,8 +225,8 @@ struct connection_handler {
		conn->write(err);
		}
		} else {
		staticstd::stringbody("Only path allowed is /upload");
		headers["Content-Length"] = std::to_string(body.size());
		staticconstexpr charbody[] ="Only path allowed is /upload";
		headers["Content-Length"] = std::to_string(sizeof(body));
		conn->set_status(server::connection::bad_request);
		conn->set_headers(headers);
		conn->write(body);
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -125,7 +125,7 @@ void process_request(work_queue& queue) {
		// some heavy work!
		std::this_thread::sleep_for(std::chrono::seconds(10));

		staticstd::map<std::string, std::string> headers = {
		std::map<std::string, std::string> headers = {
		{"Content-Length", "0"},
		{"Content-Type", "text/plain"},
		};
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -30,7 +30,7 @@ struct hello_world {
		std::ostringstream data;
		data << "Hello, " << ip << ':' << port << '!';

		staticstd::map<std::string, std::string> headers = {
		std::map<std::string, std::string> headers = {
		{"Content-Length", "0"},
		{"Content-Type", "text/plain"},
		};
Expand Down