- Notifications
You must be signed in to change notification settings - Fork425
fix http client timeout#763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
LoopinFool commentedAug 2, 2017
This change seems correct, and "looks good to me". If it gets merged, please consider also merging into other branches (0.12-release that chenzhaoyu is probably using, and 0.13-release that I am using). Thanks. |
anonimal commentedAug 29, 2017
LGTM -- apologies for the delay here, been too busy with other things. :( |
maingoh commentedNov 17, 2017
Hello, I have very rarely some connections timeout with images on google storage. I am not sure it is an issue on google side so I was wondering what this PR does and if it is possible to merge it to 0.13 branch ? Thank you, |
@maingoh -- Can you test to see whether this, when applied to 0.13-release fixes the issue for you? If so I'd be happy to merge a PR that cherry-picks this into 0.13-release. An -rc1 should be forthcoming later in the week, and it'd be great to have this fix in the next release candidate. |
maingoh commentedNov 21, 2017
I will try to test it, not sure I can give a feedback this week though.. Also I read better what the PR does and I don't think it is related to my issue, I don't destruct the client.
I am not sure this is normal or not |
Hi, in our usage of cpp-netlib(version cpp-netlib-0.12.0-final), we meet this issue:
sometimes, http request is finished, but http client destruct will be blocked until client timeout.
I think this code has a issue:
If http callback thread run before timer_.async_wait(), timer will not been cancel.
I try to fix it, WDYT?