NotificationsYou must be signed in to change notification settings
Fork425
Star2k

Fix exception propagation for client errors#754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

deanberris merged 1 commit intocpp-netlib:masterfromdeanberris:fix/http-client-error-propagation-749

Apr 7, 2017

Merged

Fix exception propagation for client errors#754

deanberris merged 1 commit intocpp-netlib:masterfromdeanberris:fix/http-client-error-propagation-749

Apr 7, 2017

Conversation

Copy link

Member

deanberris commentedApr 7, 2017

We change the cross-thread exception propagation given the asynchronous
client implementation. The previous implementation caused
double-wrapping of exceptions which works with the
std::shared_future<...> implementation, but not with
boost::shared_future<...> -- since Boost.Thread still uses
Boost.Exception for the APIs.

While we're here we make the exception propagation more explicit using
boost::rethrow_exception(...), so we can unwrap the exception that's
transported via an exception_ptr.

Fixes#749.

Fix exception propaation for client errors

95bd07c

We change the cross-thread exception propagation given the asynchronousclient implementation. The previous implementation causeddouble-wrapping of exceptions which works with thestd::shared_future<...> implementation, but not withboost::shared_future<...> -- since Boost.Thread still usesBoost.Exception for the APIs.While we're here we make the exception propagation more explicit usingboost::rethrow_exception(...), so we can unwrap the exception that'stransported via an exception_ptr.Fixes #749.