NotificationsYou must be signed in to change notification settings
Fork425
Star2k

content_length type comparison error#753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

deanberris merged 1 commit intocpp-netlib:masterfromekigwana:comp_err

Apr 7, 2017

Merged

content_length type comparison error#753

deanberris merged 1 commit intocpp-netlib:masterfromekigwana:comp_err

Apr 7, 2017

Conversation

Copy link

ekigwana commentedApr 6, 2017

Type was std::size_t and was changed to long long in commitf8ff77d. It is also initialized to
-1 in parse_headers_real(...) to help determine parse error.

Signed-off-by: Edward Kigwanaekigwana@gmail.com

content_length type was std::size_t and was changed to long long in

476dae5

commitf8ff77d. It is also initialized to-1 in parse_headers_real(...).Signed-off-by: Edward Kigwana <ekigwana@gmail.com>

deanberris self-requested a review

April 6, 2017 23:09

deanberris reviewed

Apr 6, 2017

View reviewed changes

Copy link

Member

deanberris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@ekigwana -- it's not a blocker, but have you thought about how hard it would be if we used an optional<size_t> instead for the content length? That way we don't need to do funny things with casting the value.

If that's going to take longer or more effort then I'm fine with this in the meantime.