- Notifications
You must be signed in to change notification settings - Fork425
ICC fixes#738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
ICC fixes#738
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -131,7 +131,7 @@ class basic_client_facade { | |||
| } else { | |||
| if (boost::empty(content_type_headers)) { | |||
| typedef typename char_<Tag>::type char_type; | |||
| static char_type content_type[] = "x-application/octet-stream"; | |||
| static char_type* content_type = "x-application/octet-stream"; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I suppose a better change here would be:
static char_typeconst content_type[] ="...";
Updated. |
LGTM -- thanks@eile! |
tribal-tec commentedAug 18, 2017
@deanberris your requested change actually does not work, at least with icc 17: I suggest to keep the initial code change by@eile: I just verified that this compiles. |
@tribal-tec -- that's interesting, why isn't this an ICC bug? If you send me a pull request I'd be happy to review and merge it. |
Uh oh!
There was an error while loading.Please reload this page.
const-qualify function-local static constant arrays.