- Notifications
You must be signed in to change notification settings - Fork425
ICC fixes#737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
ICC fixes#737
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Some changes seem unnecessary and unrelated.
| @@ -122,7 +122,7 @@ class basic_client_facade { | |||
| } else { | |||
| if (boost::empty(content_type_headers)) { | |||
| typedef typename char_<Tag>::type char_type; | |||
| static char_type content_type[] = "x-application/octet-stream"; | |||
| static char_type* content_type = "x-application/octet-stream"; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why do you need to make this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It's the same as#738
| @@ -227,7 +227,7 @@ class basic_client_facade { | |||
| } else { | |||
| if (boost::empty(content_type_headers)) { | |||
| typedef typename char_<Tag>::type char_type; | |||
| static char_type content_type[] = "x-application/octet-stream"; | |||
| static char_type* content_type = "x-application/octet-stream"; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Same here.
tribal-tec commentedMar 5, 2017
Corrected to only ICC fixes. |
anonimal commentedAug 29, 2017
@deanberris@glynos status? |
LGTM I'm not sure this is actually a valid change to make -- I don't understand why ICC isn't able to just initialise the character array with a literal, as that's valid C++. However, if this is something that's actively blocking adoption, then I suppose merging it is fine. |
No description provided.