forked fromglynos/cpp-netlib
- Notifications
You must be signed in to change notification settings - Fork425
Build: allow options to use Boost + OpenSSL static libs#722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
LGTM -- ideally though we really ought to just remove the dependency on Boost if we can really achieve that. |
@anonimal -- do you mind sending this change up to master as well? |
@deanberris sure, no problem. By the way, I'm currently dealing withthis cmake issue. It may or may not be related to cpp-netlib, I'll keep you posted if it ends up being an implementation issue. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Though usually not encouraged, there are use-cases for linking openssl statically (windows without openssl installed, static apps, etc.) and, though it's not as much of a security issue, the same use-cases apply to boost (so static apps don't end up linking boost dynamically because of cpp-netlib).
Default is
OFFfor both options (as I think it should be since those who need it will know when to use it).