- Notifications
You must be signed in to change notification settings - Fork425
add client size close for #712#713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
add client size close for #712#713
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| this->part_begin; | ||
| typename protocol_base::buffer_type::const_iterator end = begin; | ||
| std::advance(end, remainder); | ||
| string_typebody_string(begin, end); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do you even need this copy of the string? Why not use the range instead?
| } | ||
| } | ||
| inlineboolcheck_parse_body_complete(string_type& body_string) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It looks like you could avoid using strings here, and just deal with ranges of iterators.
4fc7dda tob950ea5Comparechenzhaoyu commentedDec 1, 2016
@deanberris , thanks for your comments, I have move body check logic to async_protocol_handler.hpp and no extra body buffer be copied now, please check, thanks~ |
deanberris left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
chenzhaoyu commentedDec 14, 2016
Hi,@deanberris , can you merge those commits from master into 0.13-release branch? |
Uh oh!
There was an error while loading.Please reload this page.
I attempt tofix#712 , if response body is completed, client side will close connection.
Comments are welcome!
regards,
chenzhaoyu