Oct 7, 2016 · Oct 3, 2016 · Oct 6, 2016 · Oct 3, 2016 · Oct 5, 2016 · Oct 5, 2016
diff --git a/CMakeLists.txt b/CMakeLists.txt
 find_package(Boost 1.58.0 REQUIRED COMPONENTS system thread)

 if (CPP-NETLIB_ENABLE_HTTPS)
    find_package( OpenSSL )
  if (APPLE)
    # If we're on OS X check for Homebrew's copy of OpenSSL instead of Apple's
    if (NOT OpenSSL_DIR)
      execute_process (COMMAND brew --prefix openssl
        OUTPUT_VARIABLE OPENSSL_ROOT_DIR
        OUTPUT_STRIP_TRAILING_WHITESPACE)
    endif()
  endif()
  find_package(OpenSSL)
 endif()

 find_package( Threads )
Original file line number	Diff line number	Diff line change
Expand Up		@@ -49,7 +49,15 @@ set(Boost_USE_MULTI_THREADED ON)
		find_package(Boost 1.58.0 REQUIRED COMPONENTS system thread)

		if (CPP-NETLIB_ENABLE_HTTPS)
		find_package( OpenSSL )
		if (APPLE)
		# If we're on OS X check for Homebrew's copy of OpenSSL instead of Apple's
		if (NOT OpenSSL_DIR)
		execute_process (COMMAND brew --prefix openssl
Copy link Member deanberrisOct 5, 2016 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I'm not a fan of requiring homebrew just like this unconditionally on APPLE. Personally, when I build the library I provide the`OpenSSL_DIR` option myself. I'd be open to accepting this if you make it so that we can detect whether the user has homebrew installed (something that could be checked at configuration time). Copy link Author anonimalOct 5, 2016 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. @deanberris Agreed. I'll make the changes. If possible, maybe I should only apply this to OSX 10.11 since other versions appear unaffected? Copy link Member deanberrisOct 6, 2016 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I think optional homebrew applies even to before OSX 10.11.
		OUTPUT_VARIABLE OPENSSL_ROOT_DIR
		OUTPUT_STRIP_TRAILING_WHITESPACE)
		endif()
		endif()
		find_package(OpenSSL)
		endif()

		find_package( Threads )
Expand Down