Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

replace std::shared_future with boost::shared_future#684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
glynos merged 4 commits intocpp-netlib:0.13-releasefromdvd0101:boost_future
Sep 24, 2016

Conversation

dvd0101
Copy link

This PR replaces std::promise and std::shared_future with boost equivalents.

This change fixes the compilation errors when theready() wrapper is used.

I've added a test and a few words of documentation.

This should address#683 and#592

boost::shared_future has a richer api, notably it has the `is_ready()`method required by the `ready()` wrapper
@deanberris
Copy link
Member

@cinghiale -- looks like the tests have failed, can you please have a look to see why?

@dvd0101
Copy link
Author

@deanberris it looks like a timeout of the install_boost script, I don't think it is related. How can I trigger a rebuild? Are you ok with an empty commit?

@dvd0101
Copy link
Author

The test timeout during the boost installation; any idea?

@deanberris
Copy link
Member

I remember this being an issue back then -- I'm not sure exactly how I resolved this, but it's a limitation of the Travis runners. So this might not be something you@cinghiale can fix. 😦

I'll defer to@glynos on whether to merge this with minimal testing. But I'm certainly fine with something that, if it works for you, is good enough to merge.

There's probably a more updated way of installing a more recent Boost installation now without having to rebuild it every time (and relying on the cache) but I've not time to have a look.

@glynosglynos merged commit9835d24 intocpp-netlib:0.13-releaseSep 24, 2016
@glynos
Copy link
Member

I merged it into 0.13-release, but I haven't fixed the failures on clang on Travis. I'll be away for a few days and take another look later next week.

Thanks for your contribution,@cinghiale!

@dvd0101
Copy link
Author

I notice that this PR has not yet been merged on master.

If you want I can take care of the fixes needed to apply it on the master and then proceed with a new PR.

@deanberris
Copy link
Member

@cinghiale -- I think@glynos and I would prefer seeing another PR just for the master branch. Since we don't merge back changes manually to master, and since this may not apply cleanly even then.

Thanks!

@dvd0101dvd0101 mentioned this pull requestOct 15, 2016
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees

@glynosglynos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@dvd0101@deanberris@glynos

[8]ページ先頭

©2009-2025 Movatter.jp