- Notifications
You must be signed in to change notification settings - Fork425
replace std::shared_future with boost::shared_future#684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
it does not compile now
boost::shared_future has a richer api, notably it has the `is_ready()`method required by the `ready()` wrapper
@cinghiale -- looks like the tests have failed, can you please have a look to see why? |
@deanberris it looks like a timeout of the install_boost script, I don't think it is related. How can I trigger a rebuild? Are you ok with an empty commit? |
The test timeout during the boost installation; any idea? |
I remember this being an issue back then -- I'm not sure exactly how I resolved this, but it's a limitation of the Travis runners. So this might not be something you@cinghiale can fix. 😦 I'll defer to@glynos on whether to merge this with minimal testing. But I'm certainly fine with something that, if it works for you, is good enough to merge. There's probably a more updated way of installing a more recent Boost installation now without having to rebuild it every time (and relying on the cache) but I've not time to have a look. |
I merged it into 0.13-release, but I haven't fixed the failures on clang on Travis. I'll be away for a few days and take another look later next week. Thanks for your contribution,@cinghiale! |
I notice that this PR has not yet been merged on master. If you want I can take care of the fixes needed to apply it on the master and then proceed with a new PR. |
@cinghiale -- I think@glynos and I would prefer seeing another PR just for the master branch. Since we don't merge back changes manually to master, and since this may not apply cleanly even then. Thanks! |
This PR replaces std::promise and std::shared_future with boost equivalents.
This change fixes the compilation errors when the
ready()
wrapper is used.I've added a test and a few words of documentation.
This should address#683 and#592