- Notifications
You must be signed in to change notification settings - Fork425
Do not assume ipv4 for source#614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There is no associated test? |
Apparently@glynos had a comment. There's really no way to test this currently as far as I can tell, at least without running a server which listens on an ipv6 address. |
@glynos Can we merge it now first, then make sure this is tested at a later date when we're refactoring the implementations? I'd be happy to do it, but I think just addressing the issue right now this way should work. |
Thanks@glynos! |
Fixes#611 -- this does not assume that address() is always convertible to ipv4.