Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Do not assume ipv4 for source#614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
glynos merged 1 commit intocpp-netlib:masterfromdeanberris:ipv6-support
Mar 9, 2016

Conversation

@deanberris
Copy link
Member

Fixes#611 -- this does not assume that address() is always convertible to ipv4.

@glynos
Copy link
Member

There is no associated test?

@deanberris
Copy link
MemberAuthor

Merging now.

Apparently@glynos had a comment.

There's really no way to test this currently as far as I can tell, at least without running a server which listens on an ipv6 address.

@deanberris
Copy link
MemberAuthor

@glynos Can we merge it now first, then make sure this is tested at a later date when we're refactoring the implementations? I'd be happy to do it, but I think just addressing the issue right now this way should work.

glynos added a commit that referenced this pull requestMar 9, 2016
@glynosglynos merged commit3ceb0e3 intocpp-netlib:masterMar 9, 2016
@deanberrisdeanberris deleted the ipv6-support branchMarch 9, 2016 21:53
@deanberris
Copy link
MemberAuthor

Thanks@glynos!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@deanberris@glynos

[8]ページ先頭

©2009-2025 Movatter.jp