- Notifications
You must be signed in to change notification settings - Fork425
Adding ssl_server example to default build#610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
* Updated ssl_server DH key to reflect current (2016) browser securityrequirements
* Updated ssl_server DH key to reflect current (2016) browser securityrequirements
Nwjy62Ueg3TUwE5D5K0xgUjyCAuHZmeI2uQUbJS6u9GeraV5h0QtH3njDS6mD64v | ||
cN5MqQXO1UTl4sQUhDPamyiJz57/o/jinHJUDLz1FGS8kOR8ecYAx8JryFgm4qPd | ||
+MYaDDIJku8f19Rnjb1SI/Y28uHL9X2dswIBAg== | ||
-----END DH PARAMETERS----- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm no security expert, but is this good to do, committing this into the repo?
This file is required for the sample to run. There was a 512-bit version in master: Since Heartbleed and POODLE, Google Chrome no longer accepts 512-bit DH keys. An end user should obviously replace these files for production usage. But for the purpose of the example, I don't see a security risk. I built that version: Ideally they would be autogenerated by the build. I can see if I can learn enough cmake magic to make that happen? I don't know enough about the build-bot to know if that would work, but I can try. |
Thanks for the explanation -- yes, we can fix this later. I'll merge this now. Cheers |
Adding ssl_server example to default build
requirements