Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[#600] Add TLS SNI hostname to client options#601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
glynos merged 1 commit intocpp-netlib:0.12-develfromtheopolis:0.12-devel
Feb 19, 2016
Merged

[#600] Add TLS SNI hostname to client options#601

glynos merged 1 commit intocpp-netlib:0.12-develfromtheopolis:0.12-devel
Feb 19, 2016

Conversation

@theopolis
Copy link

This PR adds a new member and API tohttp::client::options for an optional TLS SNI hostname. HTTPS client option callsites may optionally support/provide an SNI hostname:

http::client::options options;options.openssl_sni_hostname("my.shared.host");http::clientclient(options);

The implementation withinssl_delegate andsync_ssl arrive at an OpenSSL (and equivalent API implementations):SSL_set_tlsext_host_name. See the OpenSSL wiki forTLS SNI details, as well as usage examples.

Also, there are various non-thesis related style changes pulled in viaclang-format and the project's local format file. Please let me know if it is unacceptable to piggy-back these changes and I will try to remove them. Most of my editors auto-format so pulling out the changes isdoable. 🙀 😉

@glynos
Copy link
Member

@theopolis The CI builds are failing, could you update the PR? Also, could you apply this on the master branch? Unfortunately, master and 0.12-devel have diverged in the last few weeks, so it means some duplication of effort.

@theopolis
Copy link
Author

I'm going to attempt some E2E testing of the SNI support today. I can also submit a PR against cpp-netlib:master, but I wasn't sure if that code was a candidate for a 0.12 release. It seems there's some significant divergence from the 0.11 build w.r.t ASIO and boost.

@theopolis
Copy link
Author

You'll most likely choose to merge#602, but for posterity: this implementation of SNI does work.

Although not captured in unit tests, a traffic dump shows the TLSserver_name extension when the.openssl_sni_hostname is set. I tested against a host requiring SNI and the test client works as expected, whereas without the SNI client support it does not.

@theopolistheopolis reopened thisFeb 19, 2016
@glynos
Copy link
Member

LGTM

glynos added a commit that referenced this pull requestFeb 19, 2016
[#600] Add TLS SNI hostname to client options
@glynosglynos merged commit6689911 intocpp-netlib:0.12-develFeb 19, 2016
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@theopolis@glynos
[8]ページ先頭
©2009-2025 Movatter.jp