- Notifications
You must be signed in to change notification settings - Fork425
Fixed libraries to link, so ld will not fail on Linux with missing DSO#583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is partially correct, but I think the more correct change would be to add${CMAKE_THREAD_LIBS_INIT} to line 87 instead. Can you make that change to see whether that fixes it?
Fixed libraries to link, so ld will not fail on Linux with:'missing DSO' because of missing libpthread.
susnux commentedJan 10, 2016
@deanberris You were right, that worked. |
deanberris commentedJan 10, 2016
LGTM Awesome, thanks@susnux -- I'll wait for the integration tests to finish then merge this in. Cheers |
Fixed libraries to link, so ld will not fail on Linux with missing DSO
At least on openSUSE building of cpp-netlib (tests) fails with:
missing DSO on commandline.This happens due to missing pthread on target_link_libraries for cpp-netlib-http-server_async_run_stop_concurrency test.