- Notifications
You must be signed in to change notification settings - Fork425
Support for missing HTTP status codes#443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Support for missing HTTP status codes#443
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please remove extra whitespace.
deanberris commentedSep 9, 2014
LGTM -- please address just the two nits, and I'll merge with no issues. If you can also run clang-format on the file, that would be nice, but not required. |
lyytinen commentedSep 9, 2014
Ok, thanks! Removed the whitespace but the clang tools I don't have and won't start installing just for this if you don't mind. |
deanberris commentedSep 9, 2014
Definitely don't mind@lyytinen -- thanks again for doing this! Definitely appreciated. Now I'll just wait for Travis to do its thing and I should be able to merge this soon as that's done. 😄 Cheers |
Support for missing HTTP status codes
deanberris commentedSep 10, 2014
Took a while, but this is merged now@lyytinen -- thanks again! |
…atus-codesSupport for missing HTTP status codes
Adds support for missing HTTP status codes as a fix for issue#442.
The implementation is not that pretty as it still has a lot of redundancy (although less than in the original version) but it fixes the issue.