- Notifications
You must be signed in to change notification settings - Fork425
Conditional async_client liftetime_thread creation#431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Create a thread and add it to io_service only if io_service is internal. If internal - do not change it.
deanberris commentedSep 1, 2014
Thanks@eakraly -- I'll just wait for Travis' thoughts on this one before I merge. :) Cheers |
deanberris commentedSep 1, 2014
So the previous CI run caused the client tests to pretty much just timeout. I'm thinking you're going to have to make a change to the destructor too to check whether the service provided was external -- and if so, just delete the sentinel work object too. Do you think you can make the tests pass locally on your machine and push out another change to make the tests "green" again@eakraly? |
Fixes a bug in previews commit when if was inverted.
eakraly commentedSep 1, 2014
I see that latest CI run has finished successfully. I did make a mistake in first commit - inverted if. |
deanberris commentedSep 2, 2014
Awesome, thanks@eakraly -- LGTM. Aside from a few formatting nits (which I can change myself), this looks good. Cheers |
Conditional async_client liftetime_thread creation and fix for URI swap bug.
Conditional async_client liftetime_thread creation and fix for URI swap bug.
Create a thread and add it to io_service only if io_service is internal. If passed from outside by a user - do not change it.
Fixes#430
Fixes#422