Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Improvements of async connection timeout#417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
deanberris merged 1 commit intocpp-netlib:0.11-develfromleecoder:0.11-devel
Jul 28, 2014

Conversation

@leecoder
Copy link

No description provided.

@deanberris
Copy link
Member

Are there tests that cover these? It looks OK to me, but I'm wondering why we haven't seen anything in the tests before that would have caused this to break.

@leecoder
Copy link
Author

Sometimes, cpp-netlib-http-client_get_timeout_test failed.
(https://travis-ci.org/leecoder/cpp-netlib/jobs/29394484)
And, in my case, handle_received_data() is sometimes called with asio::error::eof after timeout.

@deanberris
Copy link
Member

Okay, that looks more convincing with test results. Thanks@leecoder -- LGTM.

deanberris added a commit that referenced this pull requestJul 28, 2014
Improvements of async connection timeout
@deanberrisdeanberris merged commit3bc6f9d intocpp-netlib:0.11-develJul 28, 2014
leecoder pushed a commit to leecoder/cpp-netlib that referenced this pull requestApr 14, 2015
Improvements of async connection timeout
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@leecoder@deanberris
[8]ページ先頭
©2009-2025 Movatter.jp