forked fromglynos/cpp-netlib
- Notifications
You must be signed in to change notification settings - Fork425
added ws2_32 and wsock32 target libraries to cmake files that is require...#355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…ired to build under mingw
Member
deanberris commentedDec 31, 2013
Thanks@MeTheRealOne -- are you able to test this change in other OSes (like Linux)? |
Author
tghosgor commentedDec 31, 2013
The changed lines specifically effect Windows&GNU environment only with if clauses but still I can test it in Linux after 1st of January. |
Author
tghosgor commentedJan 2, 2014
I pulled the forked repo and it successfully built on 3.12.6-1-ARCH using clang++. |
Member
deanberris commentedJan 6, 2014
LGTM Awesome, thanks@MeTheRealOne -- merging now. |
deanberris added a commit that referenced this pull requestJan 6, 2014
added ws2_32 and wsock32 target libraries to cmake files that is require...
leecoder pushed a commit to leecoder/cpp-netlib that referenced this pull requestApr 14, 2015
added ws2_32 and wsock32 target libraries to cmake files that is require...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...d to build under mingw