forked fromglynos/cpp-netlib
- Notifications
You must be signed in to change notification settings - Fork425
First iteration of the HTTP client for cpp-netlib v1.0.0a#350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…dded a basic test fixture for the client.
…er case for consistency.
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can we please not indent namespaces?
Member
deanberris commentedDec 18, 2013
So this change is big enough that I'm happy to merge it and iterate. Most of my comments are in the style of the code, but we can automate the fixing of that now. :) LGTM |
deanberris added a commit that referenced this pull requestDec 18, 2013
First iteration of the HTTP client for cpp-netlib v1.0.0a
MemberAuthor
glynos commentedDec 18, 2013
Awesome, thanks Dean! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is there to say? Too much for this description. Just:
a. byte_source is not implemented, therefore no request body yet
b. client_options and request_options need work
c. No SSL for now
make docto generate the class documentation (make sure doxygen is installed)And many other things that we can discuss when you have time to look at this.