Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

First iteration of the HTTP client for cpp-netlib v1.0.0a#350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
deanberris merged 105 commits intocpp-netlib:masterfromglynos:master
Dec 18, 2013

Conversation

@glynos
Copy link
Member

What is there to say? Too much for this description. Just:

  1. I not only updated the code, I updated some of the configuration too.
  2. The HTTP client is far from feature complete at this stage, but I am not too worried about that yet
    a. byte_source is not implemented, therefore no request body yet
    b. client_options and request_options need work
    c. No SSL for now
  3. The implementation diverges from the design doc:https://docs.google.com/document/d/1jUJxs99bcbxAFIWn4Slm8JIMMmrtKc3jwhBz6Da05Lk/edit#heading=h.2sedacots1jw we should discuss this
  4. I added a .travis.yml for CI: everything compiles, all tests pass for all build configurations
  5. We need to come up with a way of merging what we can from 0.11-devel into master
  6. Source documentation is incomplete
  7. Runmake doc to generate the class documentation (make sure doxygen is installed)
  8. the best thing to do first is to look at the tests, and at the simple examples (under the contrib folder)

And many other things that we can discuss when you have time to look at this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can we please not indent namespaces?

@deanberris
Copy link
Member

So this change is big enough that I'm happy to merge it and iterate. Most of my comments are in the style of the code, but we can automate the fixing of that now. :)

LGTM

deanberris added a commit that referenced this pull requestDec 18, 2013
First iteration of the HTTP client for cpp-netlib v1.0.0a
@deanberrisdeanberris merged commitf272cb4 intocpp-netlib:masterDec 18, 2013
@glynos
Copy link
MemberAuthor

Awesome, thanks Dean!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

@deanberrisdeanberris

Labels

None yet

Projects

None yet

Milestone

1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@glynos@deanberris

[8]ページ先頭

©2009-2025 Movatter.jp