- Notifications
You must be signed in to change notification settings - Fork425
Support Utf8 characters in the asynchronous connection header parser#341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…me/value parser grammar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please add a newline at the end of the file.
deanberris commentedDec 5, 2013
@rubu You probably want to pull from 0.11-devel again as I've already fixed the enum declaration problem. Is this ready for another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
So technically, this isn't my copyright as you're the author of this code. Please update properly.
deanberris commentedDec 5, 2013
Also, you probably want to add 'locale' to the required Boost libraries in the CMakeLists.txt file at the top level so this links. |
rubu commentedDec 5, 2013
Ok i repulled and the enum fix seems to be merged in fine, i updated the copyright and theres no need for locale lib since BOOST_LOCALE_NO_LIB seems to do everything fine. |
deanberris commentedDec 5, 2013
LGTM Awesome work@rubu -- thanks for this! Merging now. |
Support Utf8 characters in the asynchronous connection header parser
rubu commentedDec 5, 2013
No problem, i'll check out what's new in 0.11 and maybe switch to that:) 2013/12/5 Dean Michael Berrisnotifications@github.com
|
Support Utf8 characters in the asynchronous connection header parser
Fixes in the asynchronous connection http header name value parser grammar