- Notifications
You must be signed in to change notification settings - Fork425
Initial version of base64 encoding#300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…nchmarking tool and conclusion
… characters becomes private
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would think static char const encoding[] = "..."; would be better for many reasons here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Agreed, fixed.
deanberris commentedSep 15, 2013
LGTM -- Thanks very much, this isvery well-written! I'll merge this in as-is, and hopefully you can address that one nit in a follow-up PR. What's missing is just some documentation that's linked into the current documentation tree and we're golden! |
Initial version of base64 encoding
prantlf commentedSep 15, 2013
Thanks! I'm going to have a look how the the cpp-netlib RST documentation is organized. I like the idea of having the documentation outside the sources. I put comments to the code which should belong to the reference documentation. |
deanberris commentedSep 16, 2013
Happy to chat if you'd like to get more info -- find me on Google+ as 'mikhailberis@gmail.com' and we can hangout if you need more real-time or high-bandwidh feedback. :) |
Initial version of base64 encoding
Included:
Missing: