Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Improve build system#281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
deanberris merged 3 commits intocpp-netlib:masterfromniosHD:improve-build-system
Aug 7, 2013
Merged

Improve build system#281

deanberris merged 3 commits intocpp-netlib:masterfromniosHD:improve-build-system
Aug 7, 2013

Conversation

niosHD
Copy link

This PR works on the build system andfixes#273.

Comments are welcome!

regards,
niosHD

Using ordinary messages generates unnecessary noise when using ccmake.(Should be done for the uri submodule as well.)
@ghostghost assigneddeanberrisAug 6, 2013
if(NOT CPP-NETLIB_BUILD_SINGLE_LIB)
add_library(cppnetlib-concurrency ${CPP-NETLIB_CONCURRENCY_SRCS})
endif()

# prepend current directory to make paths absolut
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

s/absolut/absolute/ ?

@deanberris
Copy link
Member

LGTM -- please just update the typo, and let me know so I can merge this. Thanks@niosHD!

@niosHD
Copy link
Author

@deanberris: Thanks! The typo is fixed.
Could you make the messages in the CMakelists.txt of the uri submodule STATUS messages as well? (Similar to my first commit in this branch.) Would save us the trouble of an additional PR on the other repo. :) Thanks in advance!

@deanberris
Copy link
Member

LGTM -- I think@glynos can make the changes to the URI in master if he's so inclined.

Thanks@niosHD!

deanberris added a commit that referenced this pull requestAug 7, 2013
@deanberrisdeanberris merged commit8df1f1c intocpp-netlib:masterAug 7, 2013
@niosHDniosHD deleted the improve-build-system branchAugust 7, 2013 21:07
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees

@deanberrisdeanberris

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMake Error with CPP-NETLIB_BUILD_SINGLE_LIB=ON
2 participants
@niosHD@deanberris
[8]ページ先頭
©2009-2025 Movatter.jp