forked fromglynos/cpp-netlib
- Notifications
You must be signed in to change notification settings - Fork425
request_value_semantics test failed#238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Don't use incorretly the string's substring constructor
| @@ -161,6 +161,15 @@ request& request::operator=(request rhs) { | |||
| return *this; | |||
| } | |||
| void request::swap(request& other ) { | |||
| std::swap(pimpl_, other.pimpl_); | |||
| request_storage_base::swap(other); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Almost, but not quite. It should probably look like this:
using std::swap;swap(pimpl_, other.pimpl_);request_storage_base::swap(other);Just address the above comment, and it should be good to go -- good job! 👍 |
Ok, done |
LGTM |
deanberris added a commit that referenced this pull requestMay 23, 2013
request_value_semantics test failed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation in request of swap and equals is:
But it's not good, as they don't care about request_pimpl in http::request
So I defined swap and equals for request (and also added an unit test for swap)
I'm a bit unsure if this it the correct way to fix the unit test