forked fromglynos/cpp-netlib
- Notifications
You must be signed in to change notification settings - Fork425
Add ability to compile with clang without libc++.#219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
+29 −10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
To do so, supply -DCPP-NETLIB_DISABLE_LIBCXX=ON to cmake.
Member
deanberris commentedMar 1, 2013
LGTM -- Thanks! |
deanberris added a commit that referenced this pull requestMar 1, 2013
Add ability to compile with clang without libc++.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On linux systems that do not provide libc++ by default, but thatdo provide a build of clang/clang++, it's useful to be able to compile the project without using libc++ directly.
To do so, I've added a CPP-NETLIB_DISABLE_LIBCXX option to the main CMakeLists.txt---this option defaults to OFF (so as to not change the default behavior when compiling with clang) but now allows us non-OSX people to use -DCPP-NETLIB_DISABLE_LIBCXX=ON when generating build files to still use clang for compilation but build against the system default c++ standard library.
I'm also noticing that doing so was a bit of shotgun surgery on all of the associated CMakeLists.txt---is there some way we can unify the detection of CFLAGS so this isn't duplicated everywhere? I didn't investigate this too much because of my unfamiliarity with CMake.