forked fromglynos/cpp-netlib
- Notifications
You must be signed in to change notification settings - Fork425
Provide source port as part of the request#196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
deanberris commentedJan 25, 2013
LGTM -- thanks Elliot! |
deanberris added a commit that referenced this pull requestJan 25, 2013
Provide source port as part of the request
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This might be a naive implementation. For example, I couldn't figure out how to mirror the
source(request)behavior in the "hello world" example (e.g. how do I allow forsource_port(request)instead of onlyrequest.source_port?).Also, it appears that
destinationis not symmetric tosource. I expected to see an IP inrequest::destination, but I saw the URL path instead. Thus, I did not add adestination_portmember.