- Notifications
You must be signed in to change notification settings - Fork425
Add needed Boost libs and OpenSSL headers to CMake config#193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
deanberris commentedJan 22, 2013
Have you verified that this works with versions of Boost as far back as 1.51? |
3noch commentedJan 23, 2013
I've only tested against Boost 1.52. |
Provide source port number to requests
deanberris commentedJan 24, 2013
Okay, I'm willing to say that 0.9.5 is going to require Boost 1.52. I'm merging this now. LGTM |
Add needed Boost libs and OpenSSL headers to CMake config
3noch commentedJan 25, 2013
FYI: I just did some testing against Boost 1.51 and I didn't see any difference in behavior from Boost 1.52. For both of them, all the tests pass (except |
deanberris commentedJan 26, 2013
Thanks Elliot -- can you share more about the get_timeout_test failures in a different issue? I would love to have a fix for this in 0.9.5. |
3noch commentedJan 28, 2013
Sure:#198 |
I have only tested this with Visual Studio 2010. Prior to this change, the Visual Studio projects generated by CMake would not build without manual configuration changes to link against the right Boost libraries and include OpenSSL's headers.