forked fromglynos/cpp-netlib
- Notifications
You must be signed in to change notification settings - Fork425
Fix build with clang on OS X#169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…andard rvalue binding to a non-const lvalue reference.
Member
deanberris commentedNov 19, 2012
Thanks Martin! |
Klaim commentedNov 21, 2012
Ok I didn't see the issue, thanks for the fix! Good to know! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NETWORK_MESSAGE macro causes an attempt to use the non-member operator<< with an rvalue being passed as a non-const lvalue reference. Clang correctly identifies this as an error. MSVC apparently accepts this if non-standard extensions are enabled (which is the default?).
My change simply moves the operator<< to be a member function of log_record which seemed to be the least problematic way to resolve the error.
Also, in case it's relevant:
clang++ --version
Apple clang version 4.1 (tags/Apple/clang-421.11.66) (based on LLVM 3.1svn)
Target: x86_64-apple-darwin12.2.0
Thread model: posix